Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support 'bin' function push down #5246

Merged
merged 17 commits into from
Jul 25, 2022
Merged

feat: support 'bin' function push down #5246

merged 17 commits into from
Jul 25, 2022

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Jun 28, 2022

What problem does this PR solve?

Issue Number: close #5103

Problem Summary: Implement Bin function push down

What is changed and how it works?

Support Bin function push down.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • bestwoody

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 28, 2022
@ti-chi-bot
Copy link
Member

Welcome @An-DJ!

It looks like this is your first PR to pingcap/tiflash 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflash. 😃

@An-DJ An-DJ mentioned this pull request Jun 29, 2022
Closed
@bestwoody bestwoody self-requested a review June 29, 2022 10:44
@Willendless Willendless mentioned this pull request Jun 29, 2022
Open
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2022
@bestwoody
Copy link
Contributor

LGTM，please resolve conflicts at last。

bestwoody
bestwoody approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， please solve the conflict at last.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@LittleFall LittleFall self-requested a review July 22, 2022 09:58
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2022
@An-DJ
Copy link
Contributor Author

An-DJ commented Jul 22, 2022

/cc @LittleFall

@Willendless
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 22, 2022

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/hex.h                            14                 2    85.71%          11                 2    81.82%          46                 9    80.43%           2                 0   100.00%
Flash/Coprocessor/DAGUtils.cpp         347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp         1405               365    74.02%         267                69    74.16%        3082               743    75.89%         864               290    66.44%
Functions/tests/gtest_bin.cpp          211                65    69.19%           2                 0   100.00%          35                 0   100.00%          62                33    46.77%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 1977               573    71.02%         325                82    74.77%        3801              1023    73.09%        1340               513    61.72%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18811      9452             49.75%    214311  95505        55.44%

full coverage report (for internal network access only)

LittleFall
LittleFall approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2022
@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ead97da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@ti-chi-bot
Copy link
Member

@An-DJ: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 25, 2022

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/hex.h                            14                 2    85.71%          11                 2    81.82%          46                 9    80.43%           2                 0   100.00%
Flash/Coprocessor/DAGUtils.cpp         347               141    59.37%          45                11    75.56%         638               271    57.52%         412               190    53.88%
Functions/FunctionsString.cpp         1405               365    74.02%         267                69    74.16%        3082               743    75.89%         864               290    66.44%
Functions/tests/gtest_bin.cpp          211                65    69.19%           2                 0   100.00%          35                 0   100.00%          62                33    46.77%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 1977               573    71.02%         325                82    74.77%        3801              1023    73.09%        1340               513    61.72%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18811      9451             49.76%    214322  95467        55.46%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit da32955 into pingcap:master Jul 25, 2022
@An-DJ An-DJ mentioned this pull request Sep 5, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestwoody bestwoody bestwoody approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Bin function push down
6 participants
@An-DJ @ti-chi-bot @sre-bot @bestwoody @Willendless @LittleFall